Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first test workflow merge when ready #873

Merged
merged 27 commits into from
Feb 18, 2025

Conversation

girazoki
Copy link
Contributor

@girazoki girazoki commented Feb 14, 2025

Gets rid of jobs that run in the merge queue and instead creates a new workflow that runs jobs upon setting the label A8-mergeoncegreen

@girazoki girazoki added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes and removed B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Feb 14, 2025
@girazoki girazoki added the A8-mergeoncegreen Pull request is reviewed well. label Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1428 KB (no changes) ✅

flashbox runtime: 840 KB (no changes) ✅

dancelight runtime: 2172 KB (no changes) ✅

container chain template simple runtime: 1132 KB (no changes) ✅

container chain template frontier runtime: 1416 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Feb 14, 2025

Coverage Report

(master)

@@                            Coverage Diff                             @@
##           master   girazoki-try-CI-merge-on-ready-triggers     +/-   ##
==========================================================================
  Coverage   65.51%                                    65.51%   0.00%     
  Files         343                                       343             
  Lines       59504                                     59504             
==========================================================================
  Hits        38982                                     38982             
  Misses      20522                                     20522             
Files Changed Coverage

Coverage generated Mon Feb 17 16:59:00 UTC 2025

@girazoki girazoki removed the A8-mergeoncegreen Pull request is reviewed well. label Feb 14, 2025
@girazoki girazoki added the A8-mergeoncegreen Pull request is reviewed well. label Feb 14, 2025
@girazoki girazoki marked this pull request as ready for review February 14, 2025 15:43
@girazoki girazoki removed the A8-mergeoncegreen Pull request is reviewed well. label Feb 17, 2025
@girazoki girazoki added the A8-mergeoncegreen Pull request is reviewed well. label Feb 17, 2025
@girazoki girazoki requested a review from timbrinded February 17, 2025 16:50
Copy link
Contributor

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and surprisingly simple now. we can optimize the build step later, even if it means specifying a cache directory manually

@timbrinded
Copy link
Contributor

You just need to remove zombienet-tests-merge-queue-bridge-e2e and zombienet-tests-merge-queue from required CIs in repo settings.

@girazoki girazoki merged commit eba2aa7 into master Feb 18, 2025
51 checks passed
@girazoki girazoki deleted the girazoki-try-CI-merge-on-ready-triggers branch February 18, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants